From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Beilei Xing <beilei.xing@intel.com>
Subject: [dpdk-test-report] |WARNING| pw34309 [PATCH] net/i40e: add device args to disable global configuration
Date: Tue, 23 Jan 2018 11:22:31 +0100 (CET) [thread overview]
Message-ID: <20180123102231.9D7821B017@dpdk.org> (raw)
In-Reply-To: <1516702905-131472-1-git-send-email-beilei.xing@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/34309
_coding style issues_
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#74: FILE: drivers/net/i40e/i40e_ethdev.c:972:
+ static const char *valid_keys[] = {
CHECK:BRACES: Unbalanced braces around else statement
#191: FILE: drivers/net/i40e/i40e_ethdev.c:3116:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#268: FILE: drivers/net/i40e/i40e_ethdev.c:7923:
+ if (!pf->dis_global_cfg) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#292: FILE: drivers/net/i40e/i40e_ethdev.c:7947:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#338: FILE: drivers/net/i40e/i40e_ethdev.c:8110:
+ if (!pf->dis_global_cfg) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#346: FILE: drivers/net/i40e/i40e_ethdev.c:8118:
+ } else
total: 0 errors, 1 warnings, 5 checks, 312 lines checked
parent reply other threads:[~2018-01-23 10:22 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1516702905-131472-1-git-send-email-beilei.xing@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123102231.9D7821B017@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=beilei.xing@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).