From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jens Freimann <jfreimann@redhat.com>
Subject: [dpdk-test-report] |WARNING| pw34637 [PATCH 05/14] net/virtio: don't dump split virtqueue data
Date: Tue, 30 Jan 2018 00:24:51 +0100 (CET) [thread overview]
Message-ID: <20180129232451.E30931B37C@dpdk.org> (raw)
In-Reply-To: <20180129141143.13437-6-jfreimann@redhat.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/34637
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vq' - possible side-effects?
#32: FILE: drivers/net/virtio/virtqueue.h:351:
+#define VIRTQUEUE_DUMP(vq) \
+ do { \
+ if (vtpci_packed_queue((vq)->hw)) break; \
uint16_t used_idx, nused; \
used_idx = (vq)->vq_ring.used->idx; \
nused = (uint16_t)(used_idx - (vq)->vq_used_cons_idx); \
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#33: FILE: drivers/net/virtio/virtqueue.h:352:
+ do { \
+ if (vtpci_packed_queue((vq)->hw)) break; \
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#34: FILE: drivers/net/virtio/virtqueue.h:353:
+ if (vtpci_packed_queue((vq)->hw)) break; \
total: 1 errors, 1 warnings, 1 checks, 10 lines checked
parent reply other threads:[~2018-01-29 23:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180129141143.13437-6-jfreimann@redhat.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129232451.E30931B37C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jfreimann@redhat.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).