From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id E30931B37C; Tue, 30 Jan 2018 00:24:51 +0100 (CET)
In-Reply-To: <20180129141143.13437-6-jfreimann@redhat.com>
References: <20180129141143.13437-6-jfreimann@redhat.com>
To: test-report@dpdk.org
Cc: Jens Freimann <jfreimann@redhat.com>
Message-Id: <20180129232451.E30931B37C@dpdk.org>
Date: Tue, 30 Jan 2018 00:24:51 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw34637 [PATCH 05/14] net/virtio:
	don't dump split virtqueue data
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jan 2018 23:24:52 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/34637

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vq' - possible side-effects?
#32: FILE: drivers/net/virtio/virtqueue.h:351:
+#define VIRTQUEUE_DUMP(vq) \
+	do { \
+	if (vtpci_packed_queue((vq)->hw)) break; \
 	uint16_t used_idx, nused; \
 	used_idx = (vq)->vq_ring.used->idx; \
 	nused = (uint16_t)(used_idx - (vq)->vq_used_cons_idx); \

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#33: FILE: drivers/net/virtio/virtqueue.h:352:
+	do { \
+	if (vtpci_packed_queue((vq)->hw)) break; \

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#34: FILE: drivers/net/virtio/virtqueue.h:353:
+	if (vtpci_packed_queue((vq)->hw)) break; \

total: 1 errors, 1 warnings, 1 checks, 10 lines checked