From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id EB79F1B621; Mon,  5 Feb 2018 16:48:46 +0100 (CET)
In-Reply-To: <a09d0ef98a2cb7935f691ae66af34dc1e123d914.1517840652.git.pascal.mazon@6wind.com>
References: <a09d0ef98a2cb7935f691ae66af34dc1e123d914.1517840652.git.pascal.mazon@6wind.com>
To: test-report@dpdk.org
Cc: Pascal Mazon <pascal.mazon@6wind.com>
Message-Id: <20180205154846.EB79F1B621@dpdk.org>
Date: Mon,  5 Feb 2018 16:48:46 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw34990 [PATCH v2] net/tap: allow user
	MAC to be passed as args
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Feb 2018 15:48:47 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/34990

_coding style issues_


CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#69: FILE: drivers/net/tap/rte_eth_tap.c:54:
+#define ETH_TAP_MAC_ARG_FMT     "["ETH_TAP_MAC_FIXED "|" ETH_TAP_USR_MAC_FMT"]"

CHECK:SPACING: No space is necessary after a cast
#154: FILE: drivers/net/tap/rte_eth_tap.c:1597:
+		user_mac->addr_bytes[index++] = (char) strtoul(mac_byte, NULL, 16);

total: 0 errors, 0 warnings, 2 checks, 146 lines checked