From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 270E01B81A; Thu,  8 Feb 2018 17:36:00 +0100 (CET)
In-Reply-To: <1518107653-15466-4-git-send-email-matan@mellanox.com>
References: <1518107653-15466-4-git-send-email-matan@mellanox.com>
To: test-report@dpdk.org
Cc: Matan Azrad <matan@mellanox.com>
Message-Id: <20180208163600.270E01B81A@dpdk.org>
Date: Thu,  8 Feb 2018 17:36:00 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw35072 [PATCH v5 3/3] net/failsafe:
	fix calling device during RMV events
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Feb 2018 16:36:00 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35072

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 's' - possible side-effects?
#184: FILE: drivers/net/failsafe/failsafe_private.h:255:
+#define FOREACH_SUBDEV_STATE_UNSAFE(s, i, dev, state)	\
+	for (s = fs_find_next((dev), 0, state, 0, &i);	\
+	     s != NULL;					\
+	     s = fs_find_next((dev), i + 1, state, 0, &i))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#184: FILE: drivers/net/failsafe/failsafe_private.h:255:
+#define FOREACH_SUBDEV_STATE_UNSAFE(s, i, dev, state)	\
+	for (s = fs_find_next((dev), 0, state, 0, &i);	\
+	     s != NULL;					\
+	     s = fs_find_next((dev), i + 1, state, 0, &i))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#184: FILE: drivers/net/failsafe/failsafe_private.h:255:
+#define FOREACH_SUBDEV_STATE_UNSAFE(s, i, dev, state)	\
+	for (s = fs_find_next((dev), 0, state, 0, &i);	\
+	     s != NULL;					\
+	     s = fs_find_next((dev), i + 1, state, 0, &i))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#184: FILE: drivers/net/failsafe/failsafe_private.h:255:
+#define FOREACH_SUBDEV_STATE_UNSAFE(s, i, dev, state)	\
+	for (s = fs_find_next((dev), 0, state, 0, &i);	\
+	     s != NULL;					\
+	     s = fs_find_next((dev), i + 1, state, 0, &i))

total: 0 errors, 0 warnings, 4 checks, 171 lines checked