From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw35232 [PATCH 34/80] net/sfc/base: add efsys macro to get memory region size
Date: Tue, 20 Feb 2018 08:36:00 +0100 (CET) [thread overview]
Message-ID: <20180220073600.C09861B386@dpdk.org> (raw)
In-Reply-To: <1519112078-20113-35-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35232
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'esmp == NULL'
#43: FILE: drivers/net/sfc/base/ef10_rx.c:40:
+ if ((esmp == NULL) || (EFSYS_MEM_SIZE(esmp) < EFX_RXQ_SIZE(ndescs))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'esmp == NULL'
#74: FILE: drivers/net/sfc/base/ef10_tx.c:45:
+ if ((esmp == NULL) || (EFSYS_MEM_SIZE(esmp) < EFX_TXQ_SIZE(ndescs))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'esmp == NULL'
#112: FILE: drivers/net/sfc/base/efx_intr.c:294:
+ if ((esmp == NULL) || (EFSYS_MEM_SIZE(esmp) < EFX_INTR_SIZE)) {
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#127: FILE: drivers/net/sfc/base/efx_intr.c:333:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#140: FILE: drivers/net/sfc/base/efx_mcdi.c:1818:
+ uint32_t bytes = MC_CMD_MAC_NSTATS * sizeof (uint64_t);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'esmp == NULL'
#158: FILE: drivers/net/sfc/base/siena_phy.c:537:
+ if ((esmp == NULL) || (EFSYS_MEM_SIZE(esmp) < EFX_PHY_STATS_SIZE)) {
total: 1 errors, 1 warnings, 4 checks, 128 lines checked
parent reply other threads:[~2018-02-20 7:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1519112078-20113-35-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220073600.C09861B386@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).