From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id C09861B386; Tue, 20 Feb 2018 08:36:00 +0100 (CET)
In-Reply-To: <1519112078-20113-35-git-send-email-arybchenko@solarflare.com>
References: <1519112078-20113-35-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20180220073600.C09861B386@dpdk.org>
Date: Tue, 20 Feb 2018 08:36:00 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw35232 [PATCH 34/80] net/sfc/base:
	add efsys macro to get memory region size
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Feb 2018 07:36:01 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35232

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'esmp == NULL'
#43: FILE: drivers/net/sfc/base/ef10_rx.c:40:
+	if ((esmp == NULL) || (EFSYS_MEM_SIZE(esmp) < EFX_RXQ_SIZE(ndescs))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'esmp == NULL'
#74: FILE: drivers/net/sfc/base/ef10_tx.c:45:
+	if ((esmp == NULL) || (EFSYS_MEM_SIZE(esmp) < EFX_TXQ_SIZE(ndescs))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'esmp == NULL'
#112: FILE: drivers/net/sfc/base/efx_intr.c:294:
+	if ((esmp == NULL) || (EFSYS_MEM_SIZE(esmp) < EFX_INTR_SIZE)) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#127: FILE: drivers/net/sfc/base/efx_intr.c:333:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#140: FILE: drivers/net/sfc/base/efx_mcdi.c:1818:
+		uint32_t bytes = MC_CMD_MAC_NSTATS * sizeof (uint64_t);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'esmp == NULL'
#158: FILE: drivers/net/sfc/base/siena_phy.c:537:
+	if ((esmp == NULL) || (EFSYS_MEM_SIZE(esmp) < EFX_PHY_STATS_SIZE)) {

total: 1 errors, 1 warnings, 4 checks, 128 lines checked