From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw35234 [PATCH 36/80] net/sfc/base: refactor EF10 get datapath capabilities
Date: Tue, 20 Feb 2018 08:36:03 +0100 (CET) [thread overview]
Message-ID: <20180220073603.137441B390@dpdk.org> (raw)
In-Reply-To: <1519112078-20113-37-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35234
_coding style issues_
CHECK:SPACING: No space is necessary after a cast
#54: FILE: drivers/net/sfc/base/ef10_nic.c:1006:
+ (void) memset(payload, 0, sizeof (payload));
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#54: FILE: drivers/net/sfc/base/ef10_nic.c:1006:
+ (void) memset(payload, 0, sizeof (payload));
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_req' - possible side-effects?
#77: FILE: drivers/net/sfc/base/ef10_nic.c:1029:
+#define CAP_FLAGS2(_req, _flag) \
+ (((_req).emr_out_length_used >= MC_CMD_GET_CAPABILITIES_V2_OUT_LEN) && \
+ (MCDI_OUT_DWORD((_req), GET_CAPABILITIES_V2_OUT_FLAGS2) & \
+ (1u << (MC_CMD_GET_CAPABILITIES_V2_OUT_ ## _flag ## _LBN))))
total: 0 errors, 1 warnings, 2 checks, 234 lines checked
parent reply other threads:[~2018-02-20 7:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1519112078-20113-37-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220073603.137441B390@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).