From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 137441B390; Tue, 20 Feb 2018 08:36:03 +0100 (CET)
In-Reply-To: <1519112078-20113-37-git-send-email-arybchenko@solarflare.com>
References: <1519112078-20113-37-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20180220073603.137441B390@dpdk.org>
Date: Tue, 20 Feb 2018 08:36:03 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw35234 [PATCH 36/80] net/sfc/base:
	refactor EF10 get datapath capabilities
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Feb 2018 07:36:03 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35234

_coding style issues_


CHECK:SPACING: No space is necessary after a cast
#54: FILE: drivers/net/sfc/base/ef10_nic.c:1006:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#54: FILE: drivers/net/sfc/base/ef10_nic.c:1006:
+	(void) memset(payload, 0, sizeof (payload));

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_req' - possible side-effects?
#77: FILE: drivers/net/sfc/base/ef10_nic.c:1029:
+#define	CAP_FLAGS2(_req, _flag)						\
+	(((_req).emr_out_length_used >= MC_CMD_GET_CAPABILITIES_V2_OUT_LEN) && \
+	    (MCDI_OUT_DWORD((_req), GET_CAPABILITIES_V2_OUT_FLAGS2) &	\
+	    (1u << (MC_CMD_GET_CAPABILITIES_V2_OUT_ ## _flag ## _LBN))))

total: 0 errors, 1 warnings, 2 checks, 234 lines checked