From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw35240 [PATCH 47/80] net/sfc/base: add ef10 NIC board config method
Date: Tue, 20 Feb 2018 08:39:27 +0100 (CET) [thread overview]
Message-ID: <20180220073927.E7EA41B1B3@dpdk.org> (raw)
In-Reply-To: <1519112078-20113-48-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35240
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#30: FILE: drivers/net/sfc/base/ef10_nic.c:1544:
+static __checkReturn efx_rc_t
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#37: FILE: drivers/net/sfc/base/ef10_nic.c:1551:
+ if ((rc = enop->eno_board_cfg(enp)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#41: FILE: drivers/net/sfc/base/ef10_nic.c:1555:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#46: FILE: drivers/net/sfc/base/ef10_nic.c:1560:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#64: FILE: drivers/net/sfc/base/ef10_nic.c:1587:
+ if ((rc = ef10_nic_board_cfg(enp)) != 0)
total: 4 errors, 0 warnings, 1 checks, 41 lines checked
parent reply other threads:[~2018-02-20 7:39 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1519112078-20113-48-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220073927.E7EA41B1B3@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).