From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id E7EA41B1B3; Tue, 20 Feb 2018 08:39:27 +0100 (CET)
In-Reply-To: <1519112078-20113-48-git-send-email-arybchenko@solarflare.com>
References: <1519112078-20113-48-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20180220073927.E7EA41B1B3@dpdk.org>
Date: Tue, 20 Feb 2018 08:39:27 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw35240 [PATCH 47/80] net/sfc/base:
	add ef10 NIC board config method
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Feb 2018 07:39:28 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35240

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#30: FILE: drivers/net/sfc/base/ef10_nic.c:1544:
+static	__checkReturn	efx_rc_t

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#37: FILE: drivers/net/sfc/base/ef10_nic.c:1551:
+	if ((rc = enop->eno_board_cfg(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#41: FILE: drivers/net/sfc/base/ef10_nic.c:1555:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#46: FILE: drivers/net/sfc/base/ef10_nic.c:1560:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#64: FILE: drivers/net/sfc/base/ef10_nic.c:1587:
+	if ((rc = ef10_nic_board_cfg(enp)) != 0)

total: 4 errors, 0 warnings, 1 checks, 41 lines checked