* [dpdk-test-report] |WARNING| pw35285 [PATCH 52/80] net/sfc/base: move PHY/link config to ef10 NIC board cfg
[not found] <1519112078-20113-53-git-send-email-arybchenko@solarflare.com>
@ 2018-02-20 7:48 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-02-20 7:48 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35285
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#35: FILE: drivers/net/sfc/base/ef10_nic.c:1552:
+ efx_port_t *epp = &(enp->en_port);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#44: FILE: drivers/net/sfc/base/ef10_nic.c:1625:
+ if ((rc = efx_mcdi_get_phy_cfg(enp)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#48: FILE: drivers/net/sfc/base/ef10_nic.c:1629:
+ if ((rc = ef10_phy_get_link(enp, &els)) != 0)
total: 2 errors, 0 warnings, 1 checks, 300 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-02-20 7:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1519112078-20113-53-git-send-email-arybchenko@solarflare.com>
2018-02-20 7:48 ` [dpdk-test-report] |WARNING| pw35285 [PATCH 52/80] net/sfc/base: move PHY/link config to ef10 NIC board cfg checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).