From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id D0CBD2E41; Tue, 20 Feb 2018 08:48:19 +0100 (CET)
In-Reply-To: <1519112078-20113-53-git-send-email-arybchenko@solarflare.com>
References: <1519112078-20113-53-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20180220074819.D0CBD2E41@dpdk.org>
Date: Tue, 20 Feb 2018 08:48:19 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw35285 [PATCH 52/80] net/sfc/base:
	move PHY/link config to ef10 NIC board cfg
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Feb 2018 07:48:20 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35285

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#35: FILE: drivers/net/sfc/base/ef10_nic.c:1552:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#44: FILE: drivers/net/sfc/base/ef10_nic.c:1625:
+	if ((rc = efx_mcdi_get_phy_cfg(enp)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#48: FILE: drivers/net/sfc/base/ef10_nic.c:1629:
+	if ((rc = ef10_phy_get_link(enp, &els)) != 0)

total: 2 errors, 0 warnings, 1 checks, 300 lines checked