From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw35286 [PATCH 42/80] net/sfc/base: decode Medford2 FEC stats if available
Date: Tue, 20 Feb 2018 08:48:20 +0100 (CET) [thread overview]
Message-ID: <20180220074820.D38D31BE0@dpdk.org> (raw)
In-Reply-To: <1519112078-20113-43-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35286
_coding style issues_
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#39: FILE: drivers/net/sfc/base/ef10_mac.c:531:
+ if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_UNCORRECTED_ERRORS]
#61: FILE: drivers/net/sfc/base/ef10_mac.c:901:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_UNCORRECTED_ERRORS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_ERRORS]
#64: FILE: drivers/net/sfc/base/ef10_mac.c:904:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_ERRORS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE0]
#68: FILE: drivers/net/sfc/base/ef10_mac.c:908:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE0]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE1]
#73: FILE: drivers/net/sfc/base/ef10_mac.c:913:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE1]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE2]
#78: FILE: drivers/net/sfc/base/ef10_mac.c:918:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE2]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE3]
#83: FILE: drivers/net/sfc/base/ef10_mac.c:923:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE3]),
total: 1 errors, 0 warnings, 6 checks, 76 lines checked
parent reply other threads:[~2018-02-20 7:48 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1519112078-20113-43-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220074820.D38D31BE0@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).