From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id D38D31BE0; Tue, 20 Feb 2018 08:48:20 +0100 (CET)
In-Reply-To: <1519112078-20113-43-git-send-email-arybchenko@solarflare.com>
References: <1519112078-20113-43-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20180220074820.D38D31BE0@dpdk.org>
Date: Tue, 20 Feb 2018 08:48:20 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw35286 [PATCH 42/80] net/sfc/base:
	decode Medford2 FEC stats if available
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Feb 2018 07:48:21 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35286

_coding style issues_


ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#39: FILE: drivers/net/sfc/base/ef10_mac.c:531:
+		if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_UNCORRECTED_ERRORS]
#61: FILE: drivers/net/sfc/base/ef10_mac.c:901:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_UNCORRECTED_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_ERRORS]
#64: FILE: drivers/net/sfc/base/ef10_mac.c:904:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE0]
#68: FILE: drivers/net/sfc/base/ef10_mac.c:908:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE0]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE1]
#73: FILE: drivers/net/sfc/base/ef10_mac.c:913:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE1]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE2]
#78: FILE: drivers/net/sfc/base/ef10_mac.c:918:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE2]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE3]
#83: FILE: drivers/net/sfc/base/ef10_mac.c:923:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE3]),

total: 1 errors, 0 warnings, 6 checks, 76 lines checked