From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id A92704C9C; Tue, 27 Feb 2018 16:13:26 +0100 (CET)
In-Reply-To: <20180227151129.30387-1-olivier.matz@6wind.com>
References: <20180227151129.30387-1-olivier.matz@6wind.com>
To: test-report@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>
Message-Id: <20180227151326.A92704C9C@dpdk.org>
Date: Tue, 27 Feb 2018 16:13:26 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw35492 [PATCH] ethdev: return
	diagnostic when setting MAC address
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Feb 2018 15:13:26 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35492

_coding style issues_


ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#383: FILE: drivers/net/failsafe/failsafe_ops.c:1010:
+		if ((ret = fs_err(sdev, ret))) {

CHECK:CAMELCASE: Avoid CamelCase: <PRIu8>
#385: FILE: drivers/net/failsafe/failsafe_ops.c:1012:
+			      PRIu8 " with error %d", i, ret);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_eth_dev *' should also have an identifier name
#608: FILE: drivers/net/mlx5/mlx5.h:244:
+int mlx5_mac_addr_set(struct rte_eth_dev *, struct ether_addr *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ether_addr *' should also have an identifier name
#608: FILE: drivers/net/mlx5/mlx5.h:244:
+int mlx5_mac_addr_set(struct rte_eth_dev *, struct ether_addr *);

total: 1 errors, 2 warnings, 740 lines checked