From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id B12D829CB; Tue, 6 Mar 2018 02:43:29 +0100 (CET) In-Reply-To: <1520300638-134954-5-git-send-email-rosen.xu@intel.com> References: <1520300638-134954-5-git-send-email-rosen.xu@intel.com> To: test-report@dpdk.org Cc: Rosen Xu Message-Id: <20180306014329.B12D829CB@dpdk.org> Date: Tue, 6 Mar 2018 02:43:29 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw35669 [PATCH RFC 4/4] drivers/raw/ifpga_rawdev: Rawdev for Intel FPGA Device, X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2018 01:43:29 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/35669 _coding style issues_ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #205: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:104: + //*get afu_dev->num_region from Rawdev + //*get afu_dev->mem_resource from Rawdev WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #206: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:105: + //*get afu_dev->mem_resource from Rawdev + //*get afu_dev->max_vfs from Rawdev WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #207: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:106: + //*get afu_dev->max_vfs from Rawdev + //------------------------------- ERROR:TRAILING_WHITESPACE: trailing whitespace #208: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:107: +^I$ ERROR:CODE_INDENT: code indent should use tabs where possible #229: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:128: + ^I^IIFPGA_RAWDEV_PMD_ERR("Failed to enumerate fme: %d", ret);$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #229: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:128: + ^I^IIFPGA_RAWDEV_PMD_ERR("Failed to enumerate fme: %d", ret);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #229: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:128: + ^I^IIFPGA_RAWDEV_PMD_ERR("Failed to enumerate fme: %d", ret);$ ERROR:CODE_INDENT: code indent should use tabs where possible #230: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:129: + ^I^Iret = -EINVAL;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #230: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:129: + ^I^Iret = -EINVAL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #230: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:129: + ^I^Iret = -EINVAL;$ ERROR:CODE_INDENT: code indent should use tabs where possible #231: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:130: + ^I^Ireturn ret;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #231: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:130: + ^I^Ireturn ret;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #231: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:130: + ^I^Ireturn ret;$ ERROR:CODE_INDENT: code indent should use tabs where possible #232: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:131: + ^I}$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #232: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:131: + ^I}$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #232: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:131: + ^I}$ ERROR:CODE_INDENT: code indent should use tabs where possible #233: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:132: + ^Iifpga_fme_hw_init(&ifpga->hw);$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #233: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:132: + ^Iifpga_fme_hw_init(&ifpga->hw);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #233: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:132: + ^Iifpga_fme_hw_init(&ifpga->hw);$ ERROR:TRAILING_WHITESPACE: trailing whitespace #244: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:143: +^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #249: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:148: +^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #256: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:155: +^I$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #266: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:165: +^Iint ^Iret;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #278: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:177: + hw = &ifpga->hw;$ WARNING:LONG_LINE: line over 90 characters #280: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:179: + ifpga_get_afu_mmio_info(hw, afu_pr_conf->afu_id.port, &ifpga->pci_dev->mem_resource[0], &num_resource); ERROR:SPACING: spaces required around that '=' (ctx:VxV) #281: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:180: + ret=rte_fpga_do_pr(hw, afu_pr_conf->afu_id.port, afu_pr_conf->bs_path); ^ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8) #282: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:181: + if (ret) { + printf("do pr error "); ERROR:CODE_INDENT: code indent should use tabs where possible #283: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:182: + ^Iprintf("do pr error ");$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #283: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:182: + ^Iprintf("do pr error ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #283: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:182: + ^Iprintf("do pr error ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #284: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:183: + ^Ireturn ret;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #284: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:183: + ^Ireturn ret;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #284: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:183: + ^Ireturn ret;$ ERROR:TRAILING_WHITESPACE: trailing whitespace #286: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:185: +^I$ ERROR:CODE_INDENT: code indent should use tabs where possible #325: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:224: +^I^I int socket_id)$ ERROR:TRAILING_WHITESPACE: trailing whitespace #337: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:236: +^I$ WARNING:LONG_LINE: line over 90 characters #339: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:238: + snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "IFPGA:%x:%x:%x", pci_dev->addr.bus, pci_dev->addr.devid, pci_dev->addr.function); ERROR:TRAILING_WHITESPACE: trailing whitespace #340: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:239: +^I$ WARNING:LONG_LINE: line over 90 characters #391: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:290: + snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "IFPGA:%x:%x:%x", pci_dev->addr.bus, pci_dev->addr.devid, pci_dev->addr.function); ERROR:TRAILING_WHITESPACE: trailing whitespace #409: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:308: +static int $ ERROR:CODE_INDENT: code indent should use tabs where possible #411: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:310: +^I struct rte_pci_device *pci_dev)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #443: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:342: + printf("ifpga_rawdev_test ");$ WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'ifpga_rawdev_test', this function's name, in a string #443: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:342: + printf("ifpga_rawdev_test "); WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #443: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.c:342: + printf("ifpga_rawdev_test "); WARNING:LONG_LINE_COMMENT: line over 90 characters #486: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.h:36: +/*++++++++++++++++++++++++++++++++++These functions should be implemented by OPAE++++++++++++++++++++++++++++++++++*/ ERROR:TRAILING_WHITESPACE: trailing whitespace #497: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.h:47: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #497: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.h:47: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #498: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.h:48: + return 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #510: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.h:60: + return 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #516: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.h:66: + return 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #520: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.h:70: + return 0;$ WARNING:LONG_LINE_COMMENT: line over 90 characters #522: FILE: drivers/raw/ifpga_rawdev/ifpga_rawdev.h:72: +/*++++++++++++++++++++++++++++++++++These functions should be implemented by OPAE++++++++++++++++++++++++++++++++++*/ total: 19 errors, 33 warnings, 636 lines checked