From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw35693 [PATCH v2 03/14] net/sfc/base: support VXLAN filter creation
Date: Tue, 6 Mar 2018 16:28:04 +0100 (CET) [thread overview]
Message-ID: <20180306152804.D389A8DF0@dpdk.org> (raw)
In-Reply-To: <1520349899-31810-4-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35693
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#31: FILE: drivers/net/sfc/base/efx.h:2627:
+extern __checkReturn efx_rc_t
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'inner_addr == NULL'
#65: FILE: drivers/net/sfc/base/efx_filter.c:487:
+ if ((inner_addr == NULL) && (outer_addr == NULL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'outer_addr == NULL'
#65: FILE: drivers/net/sfc/base/efx_filter.c:487:
+ if ((inner_addr == NULL) && (outer_addr == NULL))
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#66: FILE: drivers/net/sfc/base/efx_filter.c:488:
+ return (EINVAL);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#82: FILE: drivers/net/sfc/base/efx_filter.c:504:
+ return (0);
total: 1 errors, 1 warnings, 3 checks, 55 lines checked
parent reply other threads:[~2018-03-06 15:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1520349899-31810-4-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306152804.D389A8DF0@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).