From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id D389A8DF0; Tue,  6 Mar 2018 16:28:04 +0100 (CET)
In-Reply-To: <1520349899-31810-4-git-send-email-arybchenko@solarflare.com>
References: <1520349899-31810-4-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20180306152804.D389A8DF0@dpdk.org>
Date: Tue,  6 Mar 2018 16:28:04 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw35693 [PATCH v2 03/14] net/sfc/base:
	support VXLAN filter creation
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Mar 2018 15:28:05 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35693

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#31: FILE: drivers/net/sfc/base/efx.h:2627:
+extern	__checkReturn	efx_rc_t

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'inner_addr == NULL'
#65: FILE: drivers/net/sfc/base/efx_filter.c:487:
+	if ((inner_addr == NULL) && (outer_addr == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'outer_addr == NULL'
#65: FILE: drivers/net/sfc/base/efx_filter.c:487:
+	if ((inner_addr == NULL) && (outer_addr == NULL))

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#66: FILE: drivers/net/sfc/base/efx_filter.c:488:
+		return (EINVAL);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#82: FILE: drivers/net/sfc/base/efx_filter.c:504:
+	return (0);

total: 1 errors, 1 warnings, 3 checks, 55 lines checked