From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 0ECF4AAC6; Thu,  8 Mar 2018 22:54:45 +0100 (CET)
In-Reply-To: <1520546046-6973-3-git-send-email-erik.g.carrillo@intel.com>
References: <1520546046-6973-3-git-send-email-erik.g.carrillo@intel.com>
To: test-report@dpdk.org
Cc: Erik Carrillo <erik.g.carrillo@intel.com>
Message-Id: <20180308215445.0ECF4AAC6@dpdk.org>
Date: Thu,  8 Mar 2018 22:54:45 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw35788 [PATCH v7 2/7] eventtimer: add
	common code
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Mar 2018 21:54:45 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35788

_coding style issues_


ERROR:SPACING: space required after that ',' (ctx:VxB)
#139: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:33:
+		RTE_FMT("EVTIMER: %s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) \
 		                                                          ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#140: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:34:
+			"
", __func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__,)))
 			                                                  ^

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#151: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:45:
+#define ADAPTER_VALID_OR_ERR_RET(adapter, retval) do { \
+	if (!adapter_valid(adapter))		       \
+		return retval;			       \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#156: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:50:
+#define FUNC_PTR_OR_ERR_RET(func, errval) do { \
+	if ((func) == NULL)		       \
+		return errval;		       \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#161: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:55:
+#define FUNC_PTR_OR_NULL_RET_WITH_ERRNO(func, errval) do { \
+	if ((func) == NULL) {				   \
+		rte_errno = errval;			   \
+		return NULL;				   \
+	}						   \
+} while (0)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#229: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:123:
+struct rte_event_timer_adapter * __rte_experimental

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#236: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:130:
+struct rte_event_timer_adapter * __rte_experimental

total: 4 errors, 3 warnings, 745 lines checked