From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id A84765F34; Fri, 9 Mar 2018 16:37:23 +0100 (CET) In-Reply-To: <1520609944-120305-6-git-send-email-rosen.xu@intel.com> References: <1520609944-120305-6-git-send-email-rosen.xu@intel.com> To: test-report@dpdk.org Cc: Rosen Xu Message-Id: <20180309153723.A84765F34@dpdk.org> Date: Fri, 9 Mar 2018 16:37:23 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw35869 [PATCH RFC 5/5] Add Intel OPAE Share Code X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2018 15:37:23 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/35869 _coding style issues_ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #138: FILE: drivers/raw/ifpga_rawdev/base/ifpga_api.c:2: +/******************************************************************************* + ERROR:SPACING: space required before the open parenthesis '(' #415: FILE: drivers/raw/ifpga_rawdev/base/ifpga_api.c:279: + if(afu_port_umsg_enable(port, enable)) ERROR:SPACING: space required before the open parenthesis '(' #429: FILE: drivers/raw/ifpga_rawdev/base/ifpga_api.c:293: + if(afu_port_umsg_set_mode(port, mode)) WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #564: FILE: drivers/raw/ifpga_rawdev/base/ifpga_api.h:2: +/******************************************************************************* + WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #648: FILE: drivers/raw/ifpga_rawdev/base/ifpga_compat.h:2: +/******************************************************************************* + ERROR:SPACING: need consistent spacing around '-' (ctx:WxV) #693: FILE: drivers/raw/ifpga_rawdev/base/ifpga_compat.h:47: +#define ALIGN(x, a) (((x) + (a) -1) &~ ((a) - 1)) ^ ERROR:SPACING: need consistent spacing around '&' (ctx:WxO) #693: FILE: drivers/raw/ifpga_rawdev/base/ifpga_compat.h:47: +#define ALIGN(x, a) (((x) + (a) -1) &~ ((a) - 1)) ^ ERROR:SPACING: space prohibited after that '~' (ctx:OxW) #693: FILE: drivers/raw/ifpga_rawdev/base/ifpga_compat.h:47: +#define ALIGN(x, a) (((x) + (a) -1) &~ ((a) - 1)) ^ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #739: FILE: drivers/raw/ifpga_rawdev/base/ifpga_defines.h:2: +/******************************************************************************* + WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #2444: FILE: drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c:2: +/******************************************************************************* + ERROR:TRAILING_WHITESPACE: trailing whitespace #3197: FILE: drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c:755: +^I$ WARNING:LONG_LINE: line over 90 characters #3208: FILE: drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c:766: + dev_info(hw, "%12s: 0x%llx - 0x%llx - paddr:0x%lx ", feature->name, WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #3258: FILE: drivers/raw/ifpga_rawdev/base/ifpga_enumerate.h:2: +/******************************************************************************* + ERROR:TRAILING_WHITESPACE: trailing whitespace #3483: FILE: drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.c:182: +^I$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #3614: FILE: drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.h:2: +/******************************************************************************* + WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #6349: FILE: drivers/raw/ifpga_rawdev/base/ifpga_hw.h:2: +/******************************************************************************* + ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #6560: FILE: drivers/raw/ifpga_rawdev/base/ifpga_port.c:62: +static int port_get_revision(struct ifpga_port_hw *port, u64* revision) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #6574: FILE: drivers/raw/ifpga_rawdev/base/ifpga_port.c:76: +static int port_get_portidx(struct ifpga_port_hw *port, u64* idx) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #6588: FILE: drivers/raw/ifpga_rawdev/base/ifpga_port.c:90: +static int port_get_latency_tolerance(struct ifpga_port_hw *port, u64* val) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #6602: FILE: drivers/raw/ifpga_rawdev/base/ifpga_port.c:104: +static int port_get_ap1_event(struct ifpga_port_hw *port, u64* val) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #6636: FILE: drivers/raw/ifpga_rawdev/base/ifpga_port.c:138: +static int port_get_ap2_event(struct ifpga_port_hw *port, u64* val) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #6670: FILE: drivers/raw/ifpga_rawdev/base/ifpga_port.c:172: +static int port_get_power_state(struct ifpga_port_hw *port, u64* val) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #6687: FILE: drivers/raw/ifpga_rawdev/base/ifpga_port.c:189: +static int port_get_userclk_freqcmd(struct ifpga_port_hw *port, u64* val) WARNING:LONG_LINE: line over 90 characters #7971: FILE: drivers/raw/ifpga_rawdev/base/opae_hw_api.h:167: +int opae_acc_send_package(struct opae_accelerator *acc, int command, void *package, u32 size); WARNING:LONG_LINE: line over 90 characters #7972: FILE: drivers/raw/ifpga_rawdev/base/opae_hw_api.h:168: +int opae_acc_recv_package(struct opae_accelerator *acc, int command, void *package, u32 size); ERROR:CODE_INDENT: code indent should use tabs where possible #8063: FILE: drivers/raw/ifpga_rawdev/base/opae_ifpga_hw_api.c:18: +^I^I^I struct feature_prop *prop)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #8234: FILE: drivers/raw/ifpga_rawdev/base/opae_ifpga_hw_api.h:63: +#define ERR_PROP(_top, _id) ^I^IPROP(_top, 0xff, _id)$ WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #8496: FILE: drivers/raw/ifpga_rawdev/base/opae_osdep.h:66: +#define BUG() pr_err("BUG at %s:%d", __func__, __LINE__) WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #8502: FILE: drivers/raw/ifpga_rawdev/base/opae_osdep.h:72: +#define BUG_ON(x) ASSERT(!(x)) WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop #8527: FILE: drivers/raw/ifpga_rawdev/base/osdep_raw/osdep_generic.h:4: +#define compiler_barrier() do { \ + asm volatile ("" : : : "memory"); \ +} while(0) ERROR:SPACING: space required before the open parenthesis '(' #8529: FILE: drivers/raw/ifpga_rawdev/base/osdep_raw/osdep_generic.h:6: +} while(0) total: 16 errors, 15 warnings, 8413 lines checked