From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 16F235F4D; Fri,  9 Mar 2018 17:44:10 +0100 (CET)
In-Reply-To: <1520613725-9176-2-git-send-email-konstantin.ananyev@intel.com>
References: <1520613725-9176-2-git-send-email-konstantin.ananyev@intel.com>
To: test-report@dpdk.org
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>
Message-Id: <20180309164410.16F235F4D@dpdk.org>
Date: Fri,  9 Mar 2018 17:44:10 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw35870 [PATCH v1 1/5] bpf: add BPF
	loading and execution framework
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Mar 2018 16:44:10 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35870

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#210: FILE: lib/librte_bpf/bpf_exec.c:25:
+		((type)(reg)[(ins)->dst_reg] op (type)(reg)[(ins)->src_reg]) ? \

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#215: FILE: lib/librte_bpf/bpf_exec.c:30:
+		((type)(reg)[(ins)->dst_reg] op (type)(ins)->imm) ? \

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#226: FILE: lib/librte_bpf/bpf_exec.c:41:
+		(type)(reg)[(ins)->dst_reg] op (type)(reg)[(ins)->src_reg])

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#233: FILE: lib/librte_bpf/bpf_exec.c:48:
+		(type)(reg)[(ins)->dst_reg] op (type)(ins)->imm)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#235: FILE: lib/librte_bpf/bpf_exec.c:50:
+#define BPF_DIV_ZERO_CHECK(bpf, reg, ins, type) do { \
+	if ((type)(reg)[(ins)->src_reg] == 0) { \
+		RTE_LOG(ERR, USER1, \
+			"%s(%p): division by 0 at pc: %#zx;
", \
+			__func__, bpf, \
+			(uintptr_t)(ins) - (uintptr_t)(bpf)->prm.ins); \
+		return 0; \
+	} \
+} while (0)

total: 0 errors, 5 warnings, 1203 lines checked