From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id BA726728A; Fri,  9 Mar 2018 17:44:15 +0100 (CET)
In-Reply-To: <1520613725-9176-6-git-send-email-konstantin.ananyev@intel.com>
References: <1520613725-9176-6-git-send-email-konstantin.ananyev@intel.com>
To: test-report@dpdk.org
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>
Message-Id: <20180309164415.BA726728A@dpdk.org>
Date: Fri,  9 Mar 2018 17:44:15 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw35874 [PATCH v1 5/5] test: add few
	eBPF samples
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Mar 2018 16:44:15 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35874

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#399: FILE: test/bpf/mbuf.h:338:
+ * mbuf */

ERROR:CODE_INDENT: code indent should use tabs where possible
#406: FILE: test/bpf/mbuf.h:345:
+                               * with a single assignment */$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#406: FILE: test/bpf/mbuf.h:345:
+                               * with a single assignment */

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#406: FILE: test/bpf/mbuf.h:345:
+typedef uint64_t MARKER64[0]; /**< marker that allows us to overwrite 8 bytes
+                               * with a single assignment */

ERROR:CODE_INDENT: code indent should use tabs where possible
#409: FILE: test/bpf/mbuf.h:348:
+        volatile int16_t cnt; /**< An internal counter value. */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#409: FILE: test/bpf/mbuf.h:348:
+        volatile int16_t cnt; /**< An internal counter value. */$

WARNING:FUNCTION_ARGUMENTS: function definition argument 'phys_addr_t' should also have an identifier name
#425: FILE: test/bpf/mbuf.h:364:
+	phys_addr_t buf_physaddr __rte_aligned(sizeof(phys_addr_t));

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#495: FILE: test/bpf/mbuf.h:434:
+			/**< First 4 flexible bytes or FD ID, dependent on
+			     PKT_RX_FDIR_* flag in ol_flags. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#495: FILE: test/bpf/mbuf.h:434:
+			     PKT_RX_FDIR_* flag in ol_flags. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#549: FILE: test/bpf/mbuf.h:488:
+	 * mbuf, it stores the direct mbuf private data size. */

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#738: FILE: test/bpf/t3.c:20:
+extern void rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m,
                                   ^

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#739: FILE: test/bpf/t3.c:21:
+	unsigned dump_len);

total: 3 errors, 9 warnings, 695 lines checked