From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 7AEADAABC; Fri, 16 Mar 2018 16:23:29 +0100 (CET)
In-Reply-To: <20180316152120.13199-17-jfreimann@redhat.com>
References: <20180316152120.13199-17-jfreimann@redhat.com>
To: test-report@dpdk.org
Cc: Jens Freimann <jfreimann@redhat.com>
Message-Id: <20180316152329.7AEADAABC@dpdk.org>
Date: Fri, 16 Mar 2018 16:23:29 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw36171 [PATCH 16/17] net/virtio: add
	support for mergeable buffers with packed
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Mar 2018 15:23:29 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/36171

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17: 
Implement support for receiving merged buffers in virtio when packed virtqueues

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#92: FILE: drivers/net/virtio/virtio_rxtx.c:119:
+
+}

ERROR:TRAILING_WHITESPACE: trailing whitespace
#168: FILE: drivers/net/virtio/virtio_rxtx.c:1073:
+^I^I^Inum = virtqueue_dequeue_burst_rx_packed(vq, rcv_pkts, len, 1, $

CHECK:SPACING: No space is necessary after a cast
#169: FILE: drivers/net/virtio/virtio_rxtx.c:1074:
+				(struct virtnet_rx *) rx_queue);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#172: FILE: drivers/net/virtio/virtio_rxtx.c:1077:
+		if (num == 0) {
+			return nb_rx;
+		}

ERROR:SPACING: space prohibited before that close parenthesis ')'
#175: FILE: drivers/net/virtio/virtio_rxtx.c:1080:
+		if (num != 1 )

WARNING:LONG_LINE: line over 90 characters
#189: FILE: drivers/net/virtio/virtio_rxtx.c:1134:
+							     (struct virtnet_rx *) rx_queue);

CHECK:SPACING: No space is necessary after a cast
#189: FILE: drivers/net/virtio/virtio_rxtx.c:1134:
+							     (struct virtnet_rx *) rx_queue);

total: 2 errors, 3 warnings, 3 checks, 178 lines checked