From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw36175 [PATCH] ethdev: return diagnostic when setting MAC address
Date: Fri, 16 Mar 2018 16:43:35 +0100 (CET) [thread overview]
Message-ID: <20180316154335.D72247CC4@dpdk.org> (raw)
In-Reply-To: <749ef7af-dde0-529e-f80c-e0b76408cd4c@solarflare.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/36175
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#79:
> drivers/net/tap/rte_eth_tap.c | 34 +++++++++++++++++++++------------
ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#145:
@@ -982,14 +995,13 @@
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#198: FILE: drivers/net/sfc/sfc_ethdev.c:941:
+ /*
+ * Neither of the two following checks can return
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#203: FILE: drivers/net/sfc/sfc_ethdev.c:946:
+ */
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#204: FILE: drivers/net/sfc/sfc_ethdev.c:947:
if (port->isolated) {
+ sfc_warn(sa, "isolated mode is active on the port");
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#217: FILE: drivers/net/sfc/sfc_ethdev.c:973:
+ if (rc != 0) {
sfc_err(sa, "cannot set filter (rc = %u)", rc);
ERROR:TRAILING_WHITESPACE: trailing whitespace
#221: FILE: drivers/net/sfc/sfc_ethdev.c:977:
+ (void)efx_mac_addr_set(sa->nic, $
ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#222: FILE: drivers/net/sfc/sfc_ethdev.c:977:
old_addr->addr_bytes);
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 4 errors, 5 warnings, 0 checks, 48 lines checked
parent reply other threads:[~2018-03-16 15:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <749ef7af-dde0-529e-f80c-e0b76408cd4c@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316154335.D72247CC4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).