From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id D72247CC4; Fri, 16 Mar 2018 16:43:35 +0100 (CET)
In-Reply-To: <749ef7af-dde0-529e-f80c-e0b76408cd4c@solarflare.com>
References: <749ef7af-dde0-529e-f80c-e0b76408cd4c@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20180316154335.D72247CC4@dpdk.org>
Date: Fri, 16 Mar 2018 16:43:35 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw36175 [PATCH] ethdev: return
	diagnostic when setting MAC address
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Mar 2018 15:43:35 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/36175

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#79: 
>   drivers/net/tap/rte_eth_tap.c           | 34 +++++++++++++++++++++------------

ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#145: 
@@ -982,14 +995,13 @@

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#198: FILE: drivers/net/sfc/sfc_ethdev.c:941:
+       /*
+        * Neither of the two following checks can return

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#203: FILE: drivers/net/sfc/sfc_ethdev.c:946:
+        */

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#204: FILE: drivers/net/sfc/sfc_ethdev.c:947:
         if (port->isolated) {
+               sfc_warn(sa, "isolated mode is active on the port");

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#217: FILE: drivers/net/sfc/sfc_ethdev.c:973:
+               if (rc != 0) {
                         sfc_err(sa, "cannot set filter (rc = %u)", rc);

ERROR:TRAILING_WHITESPACE: trailing whitespace
#221: FILE: drivers/net/sfc/sfc_ethdev.c:977:
+                       (void)efx_mac_addr_set(sa->nic, $

ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#222: FILE: drivers/net/sfc/sfc_ethdev.c:977:
old_addr->addr_bytes);

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 4 errors, 5 warnings, 0 checks, 48 lines checked