From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Sunil Kumar Kori <sunil.kori@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw36275 [PATCH] examples/l3fwd: adding event queue support
Date: Mon, 19 Mar 2018 15:57:29 +0100 (CET) [thread overview]
Message-ID: <20180319145729.8F673AAEA@dpdk.org> (raw)
In-Reply-To: <20180319134520.28155-1-sunil.kori@nxp.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/36275
_coding style issues_
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#340: FILE: examples/l3fwd/l3fwd_eventdev.c:91:
+ if ((p0 = strchr(p, ')')) == NULL)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#402: FILE: examples/l3fwd/l3fwd_eventdev.c:153:
+ if ((p0 = strchr(p, ')')) == NULL)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#469: FILE: examples/l3fwd/l3fwd_eventdev.c:220:
+ if ((p0 = strchr(p, ')')) == NULL)
WARNING:LONG_LINE: line over 90 characters
#612: FILE: examples/l3fwd/l3fwd_eventdev.c:363:
+ rx_adapter_config.config[i].connections[j].eventdev_id,
WARNING:LONG_LINE: line over 90 characters
#645: FILE: examples/l3fwd/l3fwd_eventdev.c:396:
+ rx_adapter_config.config[i].connections[j].ethdev_rx_qid_mode;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#677: FILE: examples/l3fwd/l3fwd_eventdev.c:428:
+ unsigned nb_ports;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#679: FILE: examples/l3fwd/l3fwd_eventdev.c:430:
+ unsigned lcore_id;
WARNING:LONG_LINE: line over 90 characters
#695: FILE: examples/l3fwd/l3fwd_eventdev.c:446:
+ queueid = rx_adapter_config.config[i].connections[j].ethdev_rx_qid;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#731: FILE: examples/l3fwd/l3fwd_eventdev.c:482:
+ if ((enabled_port_mask & (1 << portid)) == 0) {
+ continue;
+ }
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1105: FILE: examples/l3fwd/main.c:311:
+^I^I" ^I^I^I1: Dequeue packet via eventdev
"$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#1334: FILE: examples/l3fwd/main.c:837:
+ if (opt == CMD_LINE_OPT_DEQUEUE_MODE_NUM) {
+ dq_mode = strtoul(optarg, &end, 10);
total: 3 errors, 8 warnings, 1362 lines checked
parent reply other threads:[~2018-03-19 14:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180319134520.28155-1-sunil.kori@nxp.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319145729.8F673AAEA@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=sunil.kori@nxp.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).