From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 8F673AAEA; Mon, 19 Mar 2018 15:57:29 +0100 (CET)
In-Reply-To: <20180319134520.28155-1-sunil.kori@nxp.com>
References: <20180319134520.28155-1-sunil.kori@nxp.com>
To: test-report@dpdk.org
Cc: Sunil Kumar Kori <sunil.kori@nxp.com>
Message-Id: <20180319145729.8F673AAEA@dpdk.org>
Date: Mon, 19 Mar 2018 15:57:29 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw36275 [PATCH] examples/l3fwd: adding
	event queue support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Mar 2018 14:57:29 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/36275

_coding style issues_


ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#340: FILE: examples/l3fwd/l3fwd_eventdev.c:91:
+		if ((p0 = strchr(p, ')')) == NULL)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#402: FILE: examples/l3fwd/l3fwd_eventdev.c:153:
+		if ((p0 = strchr(p, ')')) == NULL)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#469: FILE: examples/l3fwd/l3fwd_eventdev.c:220:
+		if ((p0 = strchr(p, ')')) == NULL)

WARNING:LONG_LINE: line over 90 characters
#612: FILE: examples/l3fwd/l3fwd_eventdev.c:363:
+					rx_adapter_config.config[i].connections[j].eventdev_id,

WARNING:LONG_LINE: line over 90 characters
#645: FILE: examples/l3fwd/l3fwd_eventdev.c:396:
+				rx_adapter_config.config[i].connections[j].ethdev_rx_qid_mode;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#677: FILE: examples/l3fwd/l3fwd_eventdev.c:428:
+	unsigned nb_ports;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#679: FILE: examples/l3fwd/l3fwd_eventdev.c:430:
+	unsigned lcore_id;

WARNING:LONG_LINE: line over 90 characters
#695: FILE: examples/l3fwd/l3fwd_eventdev.c:446:
+			queueid = rx_adapter_config.config[i].connections[j].ethdev_rx_qid;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#731: FILE: examples/l3fwd/l3fwd_eventdev.c:482:
+		if ((enabled_port_mask & (1 << portid)) == 0) {
+			continue;
+		}

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1105: FILE: examples/l3fwd/main.c:311:
+^I^I"  ^I^I^I1: Dequeue packet via eventdev
"$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#1334: FILE: examples/l3fwd/main.c:837:
+		if (opt == CMD_LINE_OPT_DEQUEUE_MODE_NUM)  {
+				dq_mode = strtoul(optarg, &end, 10);

total: 3 errors, 8 warnings, 1362 lines checked