automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jens Freimann <jfreimann@redhat.com>
Subject: [dpdk-test-report] |WARNING| pw36460 [PATCH 1/1] testpmd: add parameters buffersize-before-send and flush-timeout
Date: Fri, 23 Mar 2018 16:36:22 +0100 (CET)	[thread overview]
Message-ID: <20180323153622.E1176548B@dpdk.org> (raw)
In-Reply-To: <20180323153506.28316-2-jfreimann@redhat.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/36460

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#64: FILE: app/test-pmd/fifo.c:7:
+struct rte_ring * fifo_init(uint32_t qi)

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#142: FILE: app/test-pmd/iofwd.c:113:
+	if (ncf->prev_time == 0) {
[...]
+	} else {
[...]

ERROR:SPACING: space required before the open parenthesis '('
#153: FILE: app/test-pmd/iofwd.c:124:
+			if(rte_ring_empty(ncf->f))

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#228: FILE: app/test-pmd/testpmd.c:259:
+uint16_t bsize_before_send = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#233: FILE: app/test-pmd/testpmd.c:264:
+uint16_t flush_timer = 0;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#246: FILE: app/test-pmd/testpmd.c:422:
+struct rte_ring * fifo_init(uint32_t qi, uint32_t pi)

ERROR:SPACING: exactly one space required after that #ifdef
#294: FILE: app/test-pmd/testpmd.c:1803:
+#ifdef  RTE_TEST_PMD_NOISY

total: 6 errors, 1 warnings, 268 lines checked

           reply	other threads:[~2018-03-23 15:36 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20180323153506.28316-2-jfreimann@redhat.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180323153622.E1176548B@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jfreimann@redhat.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).