From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id E1176548B; Fri, 23 Mar 2018 16:36:22 +0100 (CET)
In-Reply-To: <20180323153506.28316-2-jfreimann@redhat.com>
References: <20180323153506.28316-2-jfreimann@redhat.com>
To: test-report@dpdk.org
Cc: Jens Freimann <jfreimann@redhat.com>
Message-Id: <20180323153622.E1176548B@dpdk.org>
Date: Fri, 23 Mar 2018 16:36:22 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw36460 [PATCH 1/1] testpmd: add
	parameters buffersize-before-send and flush-timeout
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Mar 2018 15:36:23 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/36460

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#64: FILE: app/test-pmd/fifo.c:7:
+struct rte_ring * fifo_init(uint32_t qi)

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#142: FILE: app/test-pmd/iofwd.c:113:
+	if (ncf->prev_time == 0) {
[...]
+	} else {
[...]

ERROR:SPACING: space required before the open parenthesis '('
#153: FILE: app/test-pmd/iofwd.c:124:
+			if(rte_ring_empty(ncf->f))

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#228: FILE: app/test-pmd/testpmd.c:259:
+uint16_t bsize_before_send = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#233: FILE: app/test-pmd/testpmd.c:264:
+uint16_t flush_timer = 0;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#246: FILE: app/test-pmd/testpmd.c:422:
+struct rte_ring * fifo_init(uint32_t qi, uint32_t pi)

ERROR:SPACING: exactly one space required after that #ifdef
#294: FILE: app/test-pmd/testpmd.c:1803:
+#ifdef  RTE_TEST_PMD_NOISY

total: 6 errors, 1 warnings, 268 lines checked