automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Subject: [dpdk-test-report] |WARNING| pw36708 [PATCH v4 28/49] ip_pipeline: add action profile object
Date: Thu, 29 Mar 2018 20:35:49 +0200 (CEST)	[thread overview]
Message-ID: <20180329183549.91CBD1B3D3@dpdk.org> (raw)
In-Reply-To: <20180329183208.103844-29-jasvinder.singh@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/36708

_coding style issues_


ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#116: FILE: examples/ip_pipeline/action.c:57:
+		case  8: params->lb.f_hash = hash_default_key8; break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#117: FILE: examples/ip_pipeline/action.c:58:
+		case 16: params->lb.f_hash = hash_default_key16; break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#118: FILE: examples/ip_pipeline/action.c:59:
+		case 24: params->lb.f_hash = hash_default_key24; break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#119: FILE: examples/ip_pipeline/action.c:60:
+		case 32: params->lb.f_hash = hash_default_key32; break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#120: FILE: examples/ip_pipeline/action.c:61:
+		case 40: params->lb.f_hash = hash_default_key40; break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#121: FILE: examples/ip_pipeline/action.c:62:
+		case 48: params->lb.f_hash = hash_default_key48; break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#122: FILE: examples/ip_pipeline/action.c:63:
+		case 56: params->lb.f_hash = hash_default_key56; break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#123: FILE: examples/ip_pipeline/action.c:64:
+		case 64: params->lb.f_hash = hash_default_key64; break;

ERROR:SPACING: space required before the open parenthesis '('
#131: FILE: examples/ip_pipeline/action.c:72:
+	if(ap == NULL)

WARNING:LONG_LINE_COMMENT: line over 90 characters
#430: FILE: examples/ip_pipeline/cli.c:695:
+ *  [filter match | mismatch offset <key_offset> mask <key_mask> key <key_value> port <port_id>]

WARNING:LONG_LINE: line over 90 characters
#559: FILE: examples/ip_pipeline/cli.c:824:
+		if (parse_hex_string(tokens[t0 + 4], p.lb.key_mask, &p.lb.key_size) != 0) {

WARNING:LONG_LINE: line over 90 characters
#570: FILE: examples/ip_pipeline/cli.c:835:
+			if (parser_read_uint32(&p.lb.port_id[i], tokens[t0 + 6 + i]) != 0) {

WARNING:LONG_LINE: line over 90 characters
#939: FILE: examples/ip_pipeline/main.c:213:
+		printf("Error: Input port action profile initialization failed (%d)
", status);

total: 9 errors, 4 warnings, 896 lines checked

           reply	other threads:[~2018-03-29 18:35 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20180329183208.103844-29-jasvinder.singh@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180329183549.91CBD1B3D3@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).