From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 91CBD1B3D3; Thu, 29 Mar 2018 20:35:49 +0200 (CEST)
In-Reply-To: <20180329183208.103844-29-jasvinder.singh@intel.com>
References: <20180329183208.103844-29-jasvinder.singh@intel.com>
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Message-Id: <20180329183549.91CBD1B3D3@dpdk.org>
Date: Thu, 29 Mar 2018 20:35:49 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw36708 [PATCH v4 28/49] ip_pipeline:
	add action profile object
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Mar 2018 18:35:49 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/36708

_coding style issues_


ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#116: FILE: examples/ip_pipeline/action.c:57:
+		case  8: params->lb.f_hash = hash_default_key8; break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#117: FILE: examples/ip_pipeline/action.c:58:
+		case 16: params->lb.f_hash = hash_default_key16; break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#118: FILE: examples/ip_pipeline/action.c:59:
+		case 24: params->lb.f_hash = hash_default_key24; break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#119: FILE: examples/ip_pipeline/action.c:60:
+		case 32: params->lb.f_hash = hash_default_key32; break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#120: FILE: examples/ip_pipeline/action.c:61:
+		case 40: params->lb.f_hash = hash_default_key40; break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#121: FILE: examples/ip_pipeline/action.c:62:
+		case 48: params->lb.f_hash = hash_default_key48; break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#122: FILE: examples/ip_pipeline/action.c:63:
+		case 56: params->lb.f_hash = hash_default_key56; break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#123: FILE: examples/ip_pipeline/action.c:64:
+		case 64: params->lb.f_hash = hash_default_key64; break;

ERROR:SPACING: space required before the open parenthesis '('
#131: FILE: examples/ip_pipeline/action.c:72:
+	if(ap == NULL)

WARNING:LONG_LINE_COMMENT: line over 90 characters
#430: FILE: examples/ip_pipeline/cli.c:695:
+ *  [filter match | mismatch offset <key_offset> mask <key_mask> key <key_value> port <port_id>]

WARNING:LONG_LINE: line over 90 characters
#559: FILE: examples/ip_pipeline/cli.c:824:
+		if (parse_hex_string(tokens[t0 + 4], p.lb.key_mask, &p.lb.key_size) != 0) {

WARNING:LONG_LINE: line over 90 characters
#570: FILE: examples/ip_pipeline/cli.c:835:
+			if (parser_read_uint32(&p.lb.port_id[i], tokens[t0 + 6 + i]) != 0) {

WARNING:LONG_LINE: line over 90 characters
#939: FILE: examples/ip_pipeline/main.c:213:
+		printf("Error: Input port action profile initialization failed (%d)
", status);

total: 9 errors, 4 warnings, 896 lines checked