From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B94291C6AB; Wed,  4 Apr 2018 16:18:14 +0200 (CEST)
In-Reply-To: <1522851427-2855-5-git-send-email-arybchenko@solarflare.com>
References: <1522851427-2855-5-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20180404141814.B94291C6AB@dpdk.org>
Date: Wed,  4 Apr 2018 16:18:14 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw37132 [PATCH v2 4/5] net/sfc/base:
	support FW subvariant choice
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2018 14:18:15 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37132

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#39: FILE: drivers/net/sfc/base/ef10_impl.h:1172:
+extern	__checkReturn	efx_rc_t

CHECK:SPACING: No space is necessary after a cast
#77: FILE: drivers/net/sfc/base/ef10_nic.c:2313:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#77: FILE: drivers/net/sfc/base/ef10_nic.c:2313:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#100: FILE: drivers/net/sfc/base/ef10_nic.c:2336:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#107: FILE: drivers/net/sfc/base/ef10_nic.c:2343:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#120: FILE: drivers/net/sfc/base/ef10_nic.c:2356:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#120: FILE: drivers/net/sfc/base/ef10_nic.c:2356:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#142: FILE: drivers/net/sfc/base/ef10_nic.c:2378:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#238: FILE: drivers/net/sfc/base/efx_nic.c:986:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#263: FILE: drivers/net/sfc/base/efx_nic.c:1011:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#271: FILE: drivers/net/sfc/base/efx_nic.c:1019:
+	return (rc);

total: 6 errors, 2 warnings, 3 checks, 229 lines checked