automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw37135 [PATCH v3 4/5] net/sfc/base: support FW subvariant choice
Date: Wed,  4 Apr 2018 16:25:02 +0200 (CEST)	[thread overview]
Message-ID: <20180404142502.96B3B1C6CA@dpdk.org> (raw)
In-Reply-To: <1522851837-5806-5-git-send-email-arybchenko@solarflare.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37135

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#40: FILE: drivers/net/sfc/base/ef10_impl.h:1172:
+extern	__checkReturn	efx_rc_t

CHECK:SPACING: No space is necessary after a cast
#78: FILE: drivers/net/sfc/base/ef10_nic.c:2313:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#78: FILE: drivers/net/sfc/base/ef10_nic.c:2313:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#101: FILE: drivers/net/sfc/base/ef10_nic.c:2336:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#108: FILE: drivers/net/sfc/base/ef10_nic.c:2343:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#121: FILE: drivers/net/sfc/base/ef10_nic.c:2356:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#121: FILE: drivers/net/sfc/base/ef10_nic.c:2356:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#143: FILE: drivers/net/sfc/base/ef10_nic.c:2378:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#239: FILE: drivers/net/sfc/base/efx_nic.c:986:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#264: FILE: drivers/net/sfc/base/efx_nic.c:1011:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#272: FILE: drivers/net/sfc/base/efx_nic.c:1019:
+	return (rc);

total: 6 errors, 2 warnings, 3 checks, 229 lines checked

           reply	other threads:[~2018-04-04 14:25 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1522851837-5806-5-git-send-email-arybchenko@solarflare.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180404142502.96B3B1C6CA@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=arybchenko@solarflare.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).