From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 986C21CABB; Thu,  5 Apr 2018 12:13:14 +0200 (CEST)
In-Reply-To: <20180405101031.26468-15-jfreimann@redhat.com>
References: <20180405101031.26468-15-jfreimann@redhat.com>
To: test-report@dpdk.org
Cc: Jens Freimann <jfreimann@redhat.com>
Message-Id: <20180405101314.986C21CABB@dpdk.org>
Date: Thu,  5 Apr 2018 12:13:14 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw37275 [PATCH v3 14/21] vhost:
	dequeue for packed queues
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2018 10:13:14 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37275

_coding style issues_


WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#54: FILE: lib/librte_vhost/vhost.h:115:
+^Iuint16_t ^I^Iused_wrap_counter;$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#99: FILE: lib/librte_vhost/virtio_net.c:1147:
+	if (unlikely((desc->len < dev->vhost_hlen)) ||
[...]
+			RTE_LOG(ERR, VHOST_DATA,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#169: FILE: lib/librte_vhost/virtio_net.c:1217:
+		if (unlikely(dev->dequeue_zero_copy && (hpa = gpa_to_hpa(dev,

WARNING:BRACES: braces {} are not necessary for single statement blocks
#202: FILE: lib/librte_vhost/virtio_net.c:1250:
+			if (unlikely(desc->flags & VRING_DESC_F_INDIRECT)) {
+				RTE_LOG(ERR, VHOST_DATA, "INDIRECT not supported yet");
+			}

total: 1 errors, 3 warnings, 254 lines checked