automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jens Freimann <jfreimann@redhat.com>
Subject: [dpdk-test-report] |WARNING| pw37279 [PATCH v3 18/21] net/virtio: add support for mergeable buffers with packed
Date: Thu,  5 Apr 2018 12:13:18 +0200 (CEST)	[thread overview]
Message-ID: <20180405101318.500D61CAEC@dpdk.org> (raw)
In-Reply-To: <20180405101031.26468-19-jfreimann@redhat.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37279

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17: 
Implement support for receiving merged buffers in virtio when packed virtqueues

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#101: FILE: drivers/net/virtio/virtio_rxtx.c:210:
+
+}

ERROR:TRAILING_WHITESPACE: trailing whitespace
#177: FILE: drivers/net/virtio/virtio_rxtx.c:1171:
+^I^I^Inum = virtqueue_dequeue_burst_rx_packed(vq, rcv_pkts, len, 1, $

CHECK:SPACING: No space is necessary after a cast
#178: FILE: drivers/net/virtio/virtio_rxtx.c:1172:
+				(struct virtnet_rx *) rx_queue);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#181: FILE: drivers/net/virtio/virtio_rxtx.c:1175:
+		if (num == 0) {
+			return nb_rx;
+		}

ERROR:SPACING: space prohibited before that close parenthesis ')'
#184: FILE: drivers/net/virtio/virtio_rxtx.c:1178:
+		if (num != 1 )

WARNING:LONG_LINE: line over 90 characters
#198: FILE: drivers/net/virtio/virtio_rxtx.c:1232:
+							     (struct virtnet_rx *) rx_queue);

CHECK:SPACING: No space is necessary after a cast
#198: FILE: drivers/net/virtio/virtio_rxtx.c:1232:
+							     (struct virtnet_rx *) rx_queue);

total: 2 errors, 3 warnings, 3 checks, 187 lines checked

           reply	other threads:[~2018-04-05 10:13 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20180405101031.26468-19-jfreimann@redhat.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180405101318.500D61CAEC@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jfreimann@redhat.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).