From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 500D61CAEC; Thu,  5 Apr 2018 12:13:18 +0200 (CEST)
In-Reply-To: <20180405101031.26468-19-jfreimann@redhat.com>
References: <20180405101031.26468-19-jfreimann@redhat.com>
To: test-report@dpdk.org
Cc: Jens Freimann <jfreimann@redhat.com>
Message-Id: <20180405101318.500D61CAEC@dpdk.org>
Date: Thu,  5 Apr 2018 12:13:18 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw37279 [PATCH v3 18/21] net/virtio:
	add support for mergeable buffers with packed
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2018 10:13:18 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37279

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17: 
Implement support for receiving merged buffers in virtio when packed virtqueues

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#101: FILE: drivers/net/virtio/virtio_rxtx.c:210:
+
+}

ERROR:TRAILING_WHITESPACE: trailing whitespace
#177: FILE: drivers/net/virtio/virtio_rxtx.c:1171:
+^I^I^Inum = virtqueue_dequeue_burst_rx_packed(vq, rcv_pkts, len, 1, $

CHECK:SPACING: No space is necessary after a cast
#178: FILE: drivers/net/virtio/virtio_rxtx.c:1172:
+				(struct virtnet_rx *) rx_queue);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#181: FILE: drivers/net/virtio/virtio_rxtx.c:1175:
+		if (num == 0) {
+			return nb_rx;
+		}

ERROR:SPACING: space prohibited before that close parenthesis ')'
#184: FILE: drivers/net/virtio/virtio_rxtx.c:1178:
+		if (num != 1 )

WARNING:LONG_LINE: line over 90 characters
#198: FILE: drivers/net/virtio/virtio_rxtx.c:1232:
+							     (struct virtnet_rx *) rx_queue);

CHECK:SPACING: No space is necessary after a cast
#198: FILE: drivers/net/virtio/virtio_rxtx.c:1232:
+							     (struct virtnet_rx *) rx_queue);

total: 2 errors, 3 warnings, 3 checks, 187 lines checked