From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 987551CAFE; Thu,  5 Apr 2018 12:13:19 +0200 (CEST)
In-Reply-To: <20180405101031.26468-20-jfreimann@redhat.com>
References: <20180405101031.26468-20-jfreimann@redhat.com>
To: test-report@dpdk.org
Cc: Jens Freimann <jfreimann@redhat.com>
Message-Id: <20180405101319.987551CAFE@dpdk.org>
Date: Thu,  5 Apr 2018 12:13:19 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw37280 [PATCH v3 19/21] vhost:
	support mergeable rx buffers with packed queues
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2018 10:13:20 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37280

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17: 
packed virtqueues. The difference to split virtqueues is not big, it differs

ERROR:SPACING: spaces required around that '=' (ctx:VxW)
#56: FILE: lib/librte_vhost/virtio_net.c:409:
+	struct vring_desc_packed *descs= vq->desc_packed;
 	                               ^

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#144: FILE: lib/librte_vhost/virtio_net.c:493:
+	if (dev->features & (1ULL << VIRTIO_F_RING_PACKED)) {
[...]
+	} else {
[...]

ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
#145: FILE: lib/librte_vhost/virtio_net.c:494:
+		idx = vq->last_avail_idx & (vq->size -1);
 		                                     ^

total: 2 errors, 2 warnings, 276 lines checked