From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jens Freimann <jfreimann@redhat.com>
Subject: [dpdk-test-report] |WARNING| pw37281 [PATCH v3 20/21] net/virtio: add support for event suppression
Date: Thu, 5 Apr 2018 12:13:20 +0200 (CEST) [thread overview]
Message-ID: <20180405101320.DAC721CAE2@dpdk.org> (raw)
In-Reply-To: <20180405101031.26468-21-jfreimann@redhat.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37281
_coding style issues_
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#57: FILE: drivers/net/virtio/virtio_rxtx.c:130:
+ if (unlikely(virtqueue_kick_prepare_packed(vq))) {
+ virtqueue_notify(vq);
CHECK:BRACES: braces {} should be used on all arms of this statement
#128: FILE: drivers/net/virtio/virtqueue.h:296:
+ if (*event_off_wrap & RING_EVENT_FLAGS_DESC) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#132: FILE: drivers/net/virtio/virtqueue.h:300:
+ } else
CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#185: FILE: drivers/net/virtio/virtqueue.h:405:
+ new = vq->vq_signalled_avail = vq->vq_avail_idx;
total: 0 errors, 1 warnings, 3 checks, 154 lines checked
parent reply other threads:[~2018-04-05 10:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180405101031.26468-21-jfreimann@redhat.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405101320.DAC721CAE2@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jfreimann@redhat.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).