From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id DAC721CAE2; Thu,  5 Apr 2018 12:13:20 +0200 (CEST)
In-Reply-To: <20180405101031.26468-21-jfreimann@redhat.com>
References: <20180405101031.26468-21-jfreimann@redhat.com>
To: test-report@dpdk.org
Cc: Jens Freimann <jfreimann@redhat.com>
Message-Id: <20180405101320.DAC721CAE2@dpdk.org>
Date: Thu,  5 Apr 2018 12:13:20 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw37281 [PATCH v3 20/21] net/virtio:
	add support for event suppression
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2018 10:13:21 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37281

_coding style issues_


WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#57: FILE: drivers/net/virtio/virtio_rxtx.c:130:
+		if (unlikely(virtqueue_kick_prepare_packed(vq))) {
+				virtqueue_notify(vq);

CHECK:BRACES: braces {} should be used on all arms of this statement
#128: FILE: drivers/net/virtio/virtqueue.h:296:
+		if (*event_off_wrap & RING_EVENT_FLAGS_DESC) {
[...]
+		} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#132: FILE: drivers/net/virtio/virtqueue.h:300:
+		} else

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#185: FILE: drivers/net/virtio/virtqueue.h:405:
+		new = vq->vq_signalled_avail = vq->vq_avail_idx;

total: 0 errors, 1 warnings, 3 checks, 154 lines checked