From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id CB85A1CC14; Thu,  5 Apr 2018 16:31:03 +0200 (CEST)
In-Reply-To: <1522938510-5156-2-git-send-email-alejandro.lucero@netronome.com>
References: <1522938510-5156-2-git-send-email-alejandro.lucero@netronome.com>
To: test-report@dpdk.org
Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
Message-Id: <20180405143103.CB85A1CC14@dpdk.org>
Date: Thu,  5 Apr 2018 16:31:03 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw37307 [PATCH 1/4] net/nfp: add NFP
	CPP support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2018 14:31:04 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37307

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#846: FILE: drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h:27:
+#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'model' - possible side-effects?
#1748: FILE: drivers/net/nfp/nfpcore/nfp_cpp.h:211:
+#define NFP_CPP_MODEL_IS_6000(model)		     \
+		((NFP_CPP_MODEL_CHIP_of(model) >= 0x4000) && \
+		(NFP_CPP_MODEL_CHIP_of(model) < 0x7000))

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#5675: FILE: drivers/net/nfp/nfpcore/nfp_nsp.c:226:
+		printf("Host buffer out of reach %08x %" PRIx64 "
",

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#7367: FILE: drivers/net/nfp/nfpcore/nfp_rtsym.c:61:
+	printf("	name=%s, addr=%" PRIx64 ", size=%" PRIu64 ",target=%d
",

CHECK:CAMELCASE: Avoid CamelCase: <PRId64>
#7582: FILE: drivers/net/nfp/nfpcore/nfp_rtsym.c:276:
+		printf("rtsym '%s' unsupported size: %" PRId64 "
",

total: 0 errors, 0 warnings, 5 checks, 8044 lines checked