From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id BD1FA1CC27; Sat,  7 Apr 2018 21:42:04 +0200 (CEST)
In-Reply-To: <9B0331B6EBBD0E4684FBFAEDA55776F95319DB0C@HASMSX110.ger.corp.intel.com>
References: <9B0331B6EBBD0E4684FBFAEDA55776F95319DB0C@HASMSX110.ger.corp.intel.com>
To: test-report@dpdk.org
Cc: Rami Rosen <rami.rosen@intel.com>
Message-Id: <20180407194204.BD1FA1CC27@dpdk.org>
Date: Sat,  7 Apr 2018 21:42:04 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw37507 [PATCH v5 2/3] app/testpmd:
	add command for queue setup
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Apr 2018 19:42:05 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37507

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#21: 
Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>

ERROR:TRAILING_WHITESPACE: trailing whitespace
#67: FILE: app/test-pmd/cmdline.c:16038:
+/* Common result structure for queue setup */ struct $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#78: FILE: app/test-pmd/cmdline.c:16049:
+/* Common CLI fields for queue setup */ cmdline_parse_token_string_t $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#80: FILE: app/test-pmd/cmdline.c:16051:
+^ITOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, queue, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#82: FILE: app/test-pmd/cmdline.c:16053:
+^ITOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, setup, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#84: FILE: app/test-pmd/cmdline.c:16055:
+^ITOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, rxtx, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#86: FILE: app/test-pmd/cmdline.c:16057:
+^ITOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, port_id, UINT16); $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#88: FILE: app/test-pmd/cmdline.c:16059:
+^ITOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, queue_idx, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#90: FILE: app/test-pmd/cmdline.c:16061:
+^ITOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, ring_size, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#92: FILE: app/test-pmd/cmdline.c:16063:
+^ITOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, offloads, $

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 0)
#114: FILE: app/test-pmd/cmdline.c:16085:
+	if (rx && res->ring_size <= rx_free_thresh) {
[...]


ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#117: FILE: app/test-pmd/cmdline.c:16087:
[Rami Rosen] Nitpick: shouldn't it be: must > rx_free_thresh:  ? 

ERROR:TRAILING_WHITESPACE: trailing whitespace
#219: FILE: doc/guides/testpmd_app_ug/testpmd_funcs.rst:1452:
+   testpmd> queue setup (rx|tx) (port_id) (queue_idx) (ring_size) $

total: 11 errors, 2 warnings, 161 lines checked