From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 9DADC1C146; Thu, 12 Apr 2018 16:34:59 +0200 (CEST)
In-Reply-To: <20180412143422.31739-2-jfreimann@redhat.com>
References: <20180412143422.31739-2-jfreimann@redhat.com>
To: test-report@dpdk.org
Cc: Jens Freimann <jfreimann@redhat.com>
Message-Id: <20180412143459.9DADC1C146@dpdk.org>
Date: Thu, 12 Apr 2018 16:34:59 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw37980 [PATCH 1/2] testpmd: add
	parameters buffersize-before-send and flush-timeout
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Apr 2018 14:34:59 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37980

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#61: FILE: app/test-pmd/fifo.h:13:
+fifo_put(struct rte_ring *r, struct rte_mbuf **data, unsigned num)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#71: FILE: app/test-pmd/fifo.h:23:
+fifo_get(struct rte_ring *r, struct rte_mbuf **data, unsigned num)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#89: FILE: app/test-pmd/fifo.h:41:
+struct rte_ring * fifo_init(uint32_t qi, uint32_t pi);

ERROR:TRAILING_WHITESPACE: trailing whitespace
#91: FILE: app/test-pmd/fifo.h:43:
+#endif $

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#160: FILE: app/test-pmd/iofwd.c:113:
+	if (ncf->prev_time == 0) {
[...]
+	} else {
[...]

ERROR:SPACING: space required before the open parenthesis '('
#171: FILE: app/test-pmd/iofwd.c:124:
+			if(rte_ring_empty(ncf->f))

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#246: FILE: app/test-pmd/testpmd.c:259:
+uint16_t bsize_before_send = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#251: FILE: app/test-pmd/testpmd.c:264:
+uint16_t flush_timer = 0;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#264: FILE: app/test-pmd/testpmd.c:422:
+struct rte_ring * fifo_init(uint32_t qi, uint32_t pi)

ERROR:SPACING: exactly one space required after that #ifdef
#312: FILE: app/test-pmd/testpmd.c:1803:
+#ifdef  RTE_TEST_PMD_NOISY

total: 7 errors, 3 warnings, 285 lines checked