From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id DCCBD1C0F8; Fri, 13 Apr 2018 13:39:03 +0200 (CEST)
In-Reply-To: <20180413113716.27968-2-jfreimann@redhat.com>
References: <20180413113716.27968-2-jfreimann@redhat.com>
To: test-report@dpdk.org
Cc: Jens Freimann <jfreimann@redhat.com>
Message-Id: <20180413113903.DCCBD1C0F8@dpdk.org>
Date: Fri, 13 Apr 2018 13:39:03 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw38016 [PATCH v2 1/2] testpmd: add
	forwarding mode to simulate a noisy neighbour
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Apr 2018 11:39:04 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38016

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#305: FILE: app/test-pmd/noisy_vnf.h:13:
+fifo_put(struct rte_ring *r, struct rte_mbuf **data, unsigned num)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#315: FILE: app/test-pmd/noisy_vnf.h:23:
+fifo_get(struct rte_ring *r, struct rte_mbuf **data, unsigned num)

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#435: FILE: app/test-pmd/testpmd.c:257:
+uint16_t bsize_before_send = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#440: FILE: app/test-pmd/testpmd.c:262:
+uint16_t flush_timer = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#446: FILE: app/test-pmd/testpmd.c:268:
+uint64_t vnf_memory_footprint = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#452: FILE: app/test-pmd/testpmd.c:274:
+uint64_t nb_rnd_write = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#458: FILE: app/test-pmd/testpmd.c:280:
+uint64_t nb_rnd_read = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#464: FILE: app/test-pmd/testpmd.c:286:
+uint64_t nb_rnd_read_write = 0;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#475: FILE: app/test-pmd/testpmd.c:442:
+struct rte_ring * noisy_init(uint32_t qi, uint32_t pi)

total: 7 errors, 2 warnings, 451 lines checked