From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
Subject: [dpdk-test-report] |WARNING| pw38303 [PATCH] net/pcap: physical interface MAC support
Date: Tue, 17 Apr 2018 12:59:18 +0200 (CEST) [thread overview]
Message-ID: <20180417105918.6EBA8A498@dpdk.org> (raw)
In-Reply-To: <1523962694-73405-1-git-send-email-juhamatti.kuusisaari@coriant.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38303
_coding style issues_
CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#75: FILE: drivers/net/pcap/rte_eth_pcap.c:623:
+ strncpy(ifr.ifr_name, internals->if_name, sizeof(ifr.ifr_name)-1);
^
CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#76: FILE: drivers/net/pcap/rte_eth_pcap.c:624:
+ ifr.ifr_name[sizeof(ifr.ifr_name)-1] = 0;
^
WARNING:LONG_LINE: line over 90 characters
#78: FILE: drivers/net/pcap/rte_eth_pcap.c:626:
+ dev->data->dev_link.link_status = (ifr.ifr_flags & IFF_UP) ? 1 : 0;
CHECK:BRACES: Unbalanced braces around else statement
#97: FILE: drivers/net/pcap/rte_eth_pcap.c:901:
+ else {
CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#105: FILE: drivers/net/pcap/rte_eth_pcap.c:909:
+ strncpy(ifr.ifr_name, pair->value, sizeof(ifr.ifr_name)-1);
^
CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#106: FILE: drivers/net/pcap/rte_eth_pcap.c:910:
+ ifr.ifr_name[sizeof(ifr.ifr_name)-1] = 0;
^
WARNING:LONG_LINE: line over 90 characters
#108: FILE: drivers/net/pcap/rte_eth_pcap.c:912:
+ (*eth_dev)->data->mac_addrs = rte_zmalloc_socket(NULL, ETHER_ADDR_LEN, 0, vdev->device.numa_node);
WARNING:LONG_LINE: line over 90 characters
#109: FILE: drivers/net/pcap/rte_eth_pcap.c:913:
+ rte_memcpy((*eth_dev)->data->mac_addrs, ifr.ifr_addr.sa_data, ETHER_ADDR_LEN);
total: 0 errors, 3 warnings, 5 checks, 84 lines checked
parent reply other threads:[~2018-04-17 10:59 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1523962694-73405-1-git-send-email-juhamatti.kuusisaari@coriant.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417105918.6EBA8A498@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=juhamatti.kuusisaari@coriant.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).