From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 6EBA8A498; Tue, 17 Apr 2018 12:59:18 +0200 (CEST)
In-Reply-To: <1523962694-73405-1-git-send-email-juhamatti.kuusisaari@coriant.com>
References: <1523962694-73405-1-git-send-email-juhamatti.kuusisaari@coriant.com>
To: test-report@dpdk.org
Cc: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
Message-Id: <20180417105918.6EBA8A498@dpdk.org>
Date: Tue, 17 Apr 2018 12:59:18 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw38303 [PATCH] net/pcap: physical
	interface MAC support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Apr 2018 10:59:18 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38303

_coding style issues_


CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#75: FILE: drivers/net/pcap/rte_eth_pcap.c:623:
+		strncpy(ifr.ifr_name, internals->if_name, sizeof(ifr.ifr_name)-1);
 		                                                              ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#76: FILE: drivers/net/pcap/rte_eth_pcap.c:624:
+		ifr.ifr_name[sizeof(ifr.ifr_name)-1] = 0;
 		                                 ^

WARNING:LONG_LINE: line over 90 characters
#78: FILE: drivers/net/pcap/rte_eth_pcap.c:626:
+			dev->data->dev_link.link_status = (ifr.ifr_flags & IFF_UP) ? 1 : 0;

CHECK:BRACES: Unbalanced braces around else statement
#97: FILE: drivers/net/pcap/rte_eth_pcap.c:901:
+	else {

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#105: FILE: drivers/net/pcap/rte_eth_pcap.c:909:
+			strncpy(ifr.ifr_name, pair->value, sizeof(ifr.ifr_name)-1);
 			                                                       ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#106: FILE: drivers/net/pcap/rte_eth_pcap.c:910:
+			ifr.ifr_name[sizeof(ifr.ifr_name)-1] = 0;
 			                                 ^

WARNING:LONG_LINE: line over 90 characters
#108: FILE: drivers/net/pcap/rte_eth_pcap.c:912:
+				(*eth_dev)->data->mac_addrs = rte_zmalloc_socket(NULL, ETHER_ADDR_LEN, 0, vdev->device.numa_node);

WARNING:LONG_LINE: line over 90 characters
#109: FILE: drivers/net/pcap/rte_eth_pcap.c:913:
+				rte_memcpy((*eth_dev)->data->mac_addrs, ifr.ifr_addr.sa_data, ETHER_ADDR_LEN);

total: 0 errors, 3 warnings, 5 checks, 84 lines checked