* [dpdk-test-report] |WARNING| pw38303 [PATCH] net/pcap: physical interface MAC support
[not found] <1523962694-73405-1-git-send-email-juhamatti.kuusisaari@coriant.com>
@ 2018-04-17 10:59 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-04-17 10:59 UTC (permalink / raw)
To: test-report; +Cc: Juhamatti Kuusisaari
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38303
_coding style issues_
CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#75: FILE: drivers/net/pcap/rte_eth_pcap.c:623:
+ strncpy(ifr.ifr_name, internals->if_name, sizeof(ifr.ifr_name)-1);
^
CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#76: FILE: drivers/net/pcap/rte_eth_pcap.c:624:
+ ifr.ifr_name[sizeof(ifr.ifr_name)-1] = 0;
^
WARNING:LONG_LINE: line over 90 characters
#78: FILE: drivers/net/pcap/rte_eth_pcap.c:626:
+ dev->data->dev_link.link_status = (ifr.ifr_flags & IFF_UP) ? 1 : 0;
CHECK:BRACES: Unbalanced braces around else statement
#97: FILE: drivers/net/pcap/rte_eth_pcap.c:901:
+ else {
CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#105: FILE: drivers/net/pcap/rte_eth_pcap.c:909:
+ strncpy(ifr.ifr_name, pair->value, sizeof(ifr.ifr_name)-1);
^
CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#106: FILE: drivers/net/pcap/rte_eth_pcap.c:910:
+ ifr.ifr_name[sizeof(ifr.ifr_name)-1] = 0;
^
WARNING:LONG_LINE: line over 90 characters
#108: FILE: drivers/net/pcap/rte_eth_pcap.c:912:
+ (*eth_dev)->data->mac_addrs = rte_zmalloc_socket(NULL, ETHER_ADDR_LEN, 0, vdev->device.numa_node);
WARNING:LONG_LINE: line over 90 characters
#109: FILE: drivers/net/pcap/rte_eth_pcap.c:913:
+ rte_memcpy((*eth_dev)->data->mac_addrs, ifr.ifr_addr.sa_data, ETHER_ADDR_LEN);
total: 0 errors, 3 warnings, 5 checks, 84 lines checked
^ permalink raw reply [flat|nested] only message in thread