From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 3057872FD; Thu, 19 Apr 2018 09:01:11 +0200 (CEST)
In-Reply-To: <20180419065936.7288-2-jfreimann@redhat.com>
References: <20180419065936.7288-2-jfreimann@redhat.com>
To: test-report@dpdk.org
Cc: Jens Freimann <jfreimann@redhat.com>
Message-Id: <20180419070111.3057872FD@dpdk.org>
Date: Thu, 19 Apr 2018 09:01:11 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw38463 [PATCH 1/2] testpmd: add
	forwarding mode to simulate a noisy neighbour
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2018 07:01:11 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38463

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#304: FILE: app/test-pmd/noisy_vnf.h:12:
+fifo_put(struct rte_ring *r, struct rte_mbuf **data, unsigned num)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#314: FILE: app/test-pmd/noisy_vnf.h:22:
+fifo_get(struct rte_ring *r, struct rte_mbuf **data, unsigned num)

WARNING:LONG_LINE: line over 90 characters
#356: FILE: app/test-pmd/parameters.c:1110:
+			if (!strcmp(lgopts[opt_idx].name, "noisy-buffersize-before-sending")) {

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#434: FILE: app/test-pmd/testpmd.c:257:
+uint16_t noisy_bsize_before_send = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#439: FILE: app/test-pmd/testpmd.c:262:
+uint16_t noisy_flush_timer = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#445: FILE: app/test-pmd/testpmd.c:268:
+uint64_t noisy_vnf_memory_footprint = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#451: FILE: app/test-pmd/testpmd.c:274:
+uint64_t noisy_nb_rnd_write = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#457: FILE: app/test-pmd/testpmd.c:280:
+uint64_t noisy_nb_rnd_read = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#463: FILE: app/test-pmd/testpmd.c:286:
+uint64_t noisy_nb_rnd_read_write = 0;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#474: FILE: app/test-pmd/testpmd.c:442:
+struct rte_ring * noisy_init(uint32_t qi, uint32_t pi)

total: 7 errors, 3 warnings, 450 lines checked