automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw38527 [PATCH 12/23] net/sfc: support equal stride super-buffer Rx mode
Date: Thu, 19 Apr 2018 13:37:59 +0200 (CEST)	[thread overview]
Message-ID: <20180419113759.74B1C8DA5@dpdk.org> (raw)
In-Reply-To: <1524137826-5675-13-git-send-email-arybchenko@solarflare.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38527

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#177: FILE: drivers/net/sfc/sfc_ef10.h:113:
+const uint32_t * sfc_ef10_supported_ptypes_get(uint32_t tunnel_encaps);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#599: FILE: drivers/net/sfc/sfc_ef10_essb_rx.c:411:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#616: FILE: drivers/net/sfc/sfc_ef10_essb_rx.c:428:
+			return EINVAL;

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#737: FILE: drivers/net/sfc/sfc_ef10_essb_rx.c:549:
+	rxq->completed = rxq->pending_id = rxq->added = 0;

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#738: FILE: drivers/net/sfc/sfc_ef10_essb_rx.c:550:
+	rxq->left_in_completed = rxq->left_in_pending = rxq->block_size;

total: 1 errors, 2 warnings, 2 checks, 950 lines checked

           reply	other threads:[~2018-04-19 11:37 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1524137826-5675-13-git-send-email-arybchenko@solarflare.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180419113759.74B1C8DA5@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=arybchenko@solarflare.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).