From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 74B1C8DA5; Thu, 19 Apr 2018 13:37:59 +0200 (CEST)
In-Reply-To: <1524137826-5675-13-git-send-email-arybchenko@solarflare.com>
References: <1524137826-5675-13-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20180419113759.74B1C8DA5@dpdk.org>
Date: Thu, 19 Apr 2018 13:37:59 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw38527 [PATCH 12/23] net/sfc: support
	equal stride super-buffer Rx mode
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2018 11:37:59 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/38527

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#177: FILE: drivers/net/sfc/sfc_ef10.h:113:
+const uint32_t * sfc_ef10_supported_ptypes_get(uint32_t tunnel_encaps);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#599: FILE: drivers/net/sfc/sfc_ef10_essb_rx.c:411:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#616: FILE: drivers/net/sfc/sfc_ef10_essb_rx.c:428:
+			return EINVAL;

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#737: FILE: drivers/net/sfc/sfc_ef10_essb_rx.c:549:
+	rxq->completed = rxq->pending_id = rxq->added = 0;

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#738: FILE: drivers/net/sfc/sfc_ef10_essb_rx.c:550:
+	rxq->left_in_completed = rxq->left_in_pending = rxq->block_size;

total: 1 errors, 2 warnings, 2 checks, 950 lines checked